[Az.Dns] The code base is going to be refactored, the following cmdlet adds a BreakingChange announcement #28369
Conversation
…t adds a BreakingChange announcement
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
To the author of the pull request, |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a breaking change announcement for upcoming Az.Dns module refactoring, specifically for the Get-AzDnsDnssecConfig and New-AzDnsDnssecConfig cmdlets. The announcement notifies users that the SigningKey property will change from a single object to a list in future versions.
Key changes include:
- Added breaking change directives for DNSSEC config cmdlets
- Updated help documentation with corrected NAPTR record parameter ordering
- Updated module dependencies and build configurations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Dns/Dns/ChangeLog.md | Added changelog entry for breaking change announcement |
| src/Dns/Dns.Autorest/README.md | Added breaking change directive for DNSSEC config cmdlets |
| src/Dns/Dns/help/*.md | Fixed NAPTR parameter ordering and documentation in help files |
| src/Dns/Dns/Az.Dns.psd1 | Updated module dependencies and file paths |
| src/Dns/Dns.sln | Updated solution file with new project configurations |
| deprecated-output-properties: | ||
| - SigningKey | ||
| new-output-properties: | ||
| - SigningKey |
There was a problem hiding this comment.
The breaking change directive lists the same property 'SigningKey' under both deprecated-output-properties and new-output-properties. This is confusing and should clarify that it's a type change rather than deprecation and addition of a new property.
| - SigningKey | |
| output-property-type-changed: | |
| - SigningKey |
Copilot uses AI. Check for mistakes.
|
|
||
| # Format files (.ps1xml) to be loaded when importing this module | ||
| FormatsToProcess = 'Dns.Autorest\Az.Dns.format.ps1xml' | ||
| FormatsToProcess = 'Dns.Autorest/Az.Dns.format.ps1xml' |
There was a problem hiding this comment.
The path separator has been changed from backslash to forward slash. This should be consistent throughout the file for cross-platform compatibility.
Copilot uses AI. Check for mistakes.
Description
#28318
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.